This repository was archived by the owner on Nov 6, 2020. It is now read-only.
Expose transaction insertion in sync lib #609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -30,7 +30,7 @@ pub enum SyncMessage { | |||
| /// Hashes of blocks imported to blockchain | |||
| good: Vec<H256>, | |||
| /// Hashes of blocks not imported to blockchain | |||
| bad: Vec<H256>, | |||
| retracted: Vec<H256>, | |||
There was a problem hiding this comment.
retracted != bad. Bad blocks are the ones which were not imported due to an error. You need additional field for dead blocks - ones which were removed from the canonical chain.
There was a problem hiding this comment.
this is from https://github.com/ethcore/parity/pull/607
review/merge it first)
arkpar
added
A4-gotissues 💥
Conflicts: sync/src/chain.rs
NikVolf
added
A3-inprogress ⏳
Merged
|
required for #587 |
NikVolf
changed the title
| where T: Fn(&Address) -> U256 | ||
| { | ||
| let mut queue = self.transaction_queue.lock().unwrap(); | ||
| queue.add(transaction, fetch_nonce); |
There was a problem hiding this comment.
add returns a result right now so this will be a warning (after merge with master). We should forward the result up to sync/src/lib.rs
tomusdrw
added
A8-looksgood 🦄
Closed
gavofyork
added a commit
that referenced
this pull request
Mar 10, 2016
Expose transaction insertion in sync lib
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tiny one, should go after 607