This repository was archived by the owner on Nov 6, 2020. It is now read-only.
run cargo fmt, (not meant to be merged) #5624
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NikVolf
reviewed
May 15, 2017
| @@ -21,7 +21,8 @@ const MIN_RUSTC_VERSION: &'static str = "1.15.1"; | |||
| fn main() { | |||
| let is = rustc_version::version().unwrap(); | |||
| let required = MIN_RUSTC_VERSION.parse().unwrap(); | |||
| assert!(is >= required, format!(" | |||
| assert!(is >= required, | |||
There was a problem hiding this comment.
already discussed, we will not align code this way, but
assert!(is >= required,
other_para,
final_param);or
assert!(
is >= required,
other_para,
final_param
);There was a problem hiding this comment.
and almost everything below is about this
There was a problem hiding this comment.
probably, the rustfmt is confused by the multiple lines in format!. Let me check if rustfmt has an option to format like this.
NikVolf
reviewed
May 15, 2017
| &cmd.dirs.ipc_path(), | ||
| Arc::new(Miner::with_spec(&spec)), | ||
| ).map_err(|e| format!("Client service error: {:?}", e))?; | ||
| let service = ClientService::start(client_config, &spec, &client_path, &snapshot_path, &cmd.dirs.ipc_path(), Arc::new(Miner::with_spec(&spec))) |
There was a problem hiding this comment.
not sure which option controls the behavior...
5chdn
added
the
A1-onice 🌨
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is only for preview purpose.