Stratum: submit share

[akandratovich]

Hello, I'm using stratum protocol in Parity.
When I submit invalid work package, Parity returns me okay response, but should return failure.
In parity console I can read error message.

➜  telnet 127.0.0.1 8009
Trying 127.0.0.1...
Connected to localhost.
Escape character is '^]'.
{"id": 1, "method": "mining.subscribe", "params": []}
{"result":["0x","0x0af13ffce1f58840c73dbe6620c1fbae71b1597c14f9288cfc24564d53fd752d","0x0000000000000000000000000000000000000000000000000000000000000000","0x0000442c8c3c029690f2e7392750b8b733761883347c23be3b26167b60ceda2a","0x537"],"id":1}
{"id": 3, "method": "mining.authorize", "params": ["87d9d3abbd40849370e6b4bae08bb0659360a822.RIG","87d9d3abbd40849370e6b4bae08bb0659360a822.RIG"]}
{"result":true,"id":3}
{"id": 4, "method": "mining.submit", "params": ["87d9d3abbd40849370e6b4bae08bb0659360a822.RIG","0x","0xd98ed6f29e59f16a","0xf6d586828e6f68e17143f8879e1e5b4d39383fc318cf5770da54b1d2c06bcad8","0x29c5286a266e47da92601eb3eb006d459d60f084a1a559853e40954607212769"]}
{"result":true,"id":4}
{ "id": 521, "method": "mining.notify", "params": ["0x", "0x0af13ffce1f58840c73dbe6620c1fbae71b1597c14f9288cfc24564d53fd752d","0x0000000000000000000000000000000000000000000000000000000000000000","0x0000442c8c3c029690f2e7392750b8b733761883347c23be3b26167b60ceda2a","0x537"] }

...
2017-08-08 19:58:14     0/25 peers   117 KiB chain 5 MiB db 0 bytes queue 448 bytes sync  RPC:  0 conn,  0 req/s,  59 µs
2017-08-08 19:58:44  Submitted solution rejected: Block unknown or out of date.
2017-08-08 19:58:44  submit_seal error: PowHashInvalid
2017-08-08 19:58:44     0/25 peers   117 KiB chain 5 MiB db 0 bytes queue 448 bytes sync  RPC:  0 conn,  0 req/s,  59 µs
...

I'm using Olympic chain. Main chain has the same behaviour.

[20:48:51] andrew in ~ $ parity --version
Parity
  version Parity/v1.7.0-beta-5f2cabd-20170727/x86_64-macos/rustc1.18.0
Copyright 2015, 2016, 2017 Parity Technologies (UK) Ltd
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>.
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

By Wood/Paronyan/Kotewicz/Drwięga/Volf
   Habermeier/Czaban/Greeff/Gotchac/Redmann

I think the problem cause is here (no error handling): https://github.com/paritytech/parity/blob/master/ethcore/src/miner/stratum.rs#L147

Unfortunately, I'm not familiar with Rust.

[5chdn]

Which version of Parity is that?

[akandratovich]

@5chdn I've updated issue.

[akandratovich]

I think the problem cause is here (no error handling): https://github.com/paritytech/parity/blob/master/ethcore/src/miner/stratum.rs#L147

Unfortunately, I'm not familiar with Rust.

[debris]

thanks for tips @Kondratovich . #6260 should fix the issue