Skip to content
This repository was archived by the owner on Nov 6, 2020. It is now read-only.

Build Ethash DAG size table at runtime #161

Closed
arkpar opened this issue Jan 17, 2016 · 7 comments
Closed

Build Ethash DAG size table at runtime #161

arkpar opened this issue Jan 17, 2016 · 7 comments
Labels
F8-enhancement 🎊 An additional feature request. P7-nicetohave 🐕 Issue is worth doing eventually.

Comments

@arkpar
Copy link
Collaborator

arkpar commented Jan 17, 2016

No description provided.

@arkpar arkpar added F8-enhancement 🎊 An additional feature request. P7-nicetohave 🐕 Issue is worth doing eventually. labels Jan 17, 2016
@NikVolf NikVolf mentioned this issue Feb 17, 2016
Closed
@peterjoel
Copy link
Contributor

May I take this task please?

@NikVolf
Copy link
Contributor

NikVolf commented Feb 17, 2016

sure, Peter, you are welcome

@peterjoel
Copy link
Contributor

I presume the best place to implement them would be directly inside the existing get_data_size and get_cache_size functions of ethash/compute.rs.

As for tests, should I compare against the full known 2048 blocks, or just a selection of values?

@gavofyork
Copy link
Contributor

tests should run fairly quickly. maybe just a well chosen selection would be sufficient?

@peterjoel
Copy link
Contributor

compute.rs has tests in the same file. Should I continue that?

peterjoel pushed a commit to peterjoel/parity that referenced this issue Feb 18, 2016
added tests for openethereum#161
202477d
@NikVolf
Copy link
Contributor

NikVolf commented Feb 18, 2016

yeah, no standards about it so far

@gavofyork
Copy link
Contributor

yes that's pretty much the convention we're following currently.

peterjoel pushed a commit to peterjoel/parity that referenced this issue Feb 20, 2016
Tests for issue openethereum#161
d4e8ef3
peterjoel pushed a commit to peterjoel/parity that referenced this issue Feb 20, 2016
Tests for issue openethereum#161
b15fb30
peterjoel pushed a commit to peterjoel/parity that referenced this issue Feb 20, 2016
Implementations of get_cache_size and get_data_size in Rust (issue op…
ca05738 
…enethereum#161)

Removed sizes module, containing replaced data tables
peterjoel pushed a commit to peterjoel/parity that referenced this issue Feb 20, 2016
Implementations of get_cache_size and get_data_size in Rust (issue op…
5780d96 
…enethereum#161)

Removed sizes module, containing replaced data tables
peterjoel pushed a commit to peterjoel/parity that referenced this issue Feb 20, 2016
Implementations of get_cache_size and get_data_size in Rust (issue op…
b1e8c00 
…enethereum#161)

Removed sizes module, containing replaced data tables
peterjoel pushed a commit to peterjoel/parity that referenced this issue Feb 20, 2016
Implementations of get_cache_size and get_data_size in Rust (issue op…
38dcc5f 
…enethereum#161)

Removed sizes module, containing replaced data tables
peterjoel pushed a commit to peterjoel/parity that referenced this issue Feb 20, 2016
Implementations of get_cache_size and get_data_size in Rust (issue op…
b4fe7b7 
…enethereum#161)

Removed sizes module, containing replaced data tables
peterjoel pushed a commit to peterjoel/parity that referenced this issue Feb 20, 2016
Tests for issue openethereum#161
16b6556
peterjoel pushed a commit to peterjoel/parity that referenced this issue Feb 20, 2016
Implementations of get_cache_size and get_data_size in Rust (issue op…
b4998e2 
…enethereum#161)

Removed sizes module, containing replaced data tables
peterjoel pushed a commit to peterjoel/parity that referenced this issue Feb 20, 2016
Implementations of get_cache_size and get_data_size in Rust (issue op…
a127d8b 
…enethereum#161)

Removed sizes module, containing replaced data tables
peterjoel pushed a commit to peterjoel/parity that referenced this issue Feb 21, 2016
Tests for issue openethereum#161
132cfac 
Implementations of get_cache_size and get_data_size in Rust (issue openethereum#161)
Removed sizes module, containing replaced data tables

Fixed whitespace issues after code review
peterjoel pushed a commit to peterjoel/parity that referenced this issue Feb 21, 2016
Tests for issue openethereum#161
ce81a24 
Implementations of get_cache_size and get_data_size in Rust (issue openethereum#161)
Removed sizes module, containing replaced data tables

Fixed whitespace issues after code review
NikVolf added a commit that referenced this issue Feb 25, 2016
@NikVolf
Merge pull request #482 from peterjoel/issue_161
b6a6bc0 
Rust implementations to replace data tables (#161)
@NikVolf NikVolf closed this as completed Feb 25, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
F8-enhancement 🎊 An additional feature request. P7-nicetohave 🐕 Issue is worth doing eventually.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@gavofyork @peterjoel @NikVolf @arkpar