Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Minimise calls to update sealing #1372

Closed
gavofyork opened this issue Jun 21, 2016 · 2 comments
Closed

Minimise calls to update sealing #1372

gavofyork opened this issue Jun 21, 2016 · 2 comments
Labels
F7-optimisation 💊 An enhancement to provide better overall performance in terms of time-to-completion for a task.

Comments

@gavofyork
Copy link
Contributor

update_sealing will be called multiple times here when there's a new block which reorganises the chain (once for each retracted block + additional update sealing at the end of the function).

It should amalgamate into a single call.
@gavofyork gavofyork added the F7-optimisation 💊 An enhancement to provide better overall performance in terms of time-to-completion for a task. label Jun 21, 2016
@gavofyork gavofyork changed the title Minimise update_sealing calls Minimise calls to update sealing Jun 21, 2016
@gavofyork gavofyork mentioned this issue Jun 21, 2016
Merged
@arkpar
Copy link
Collaborator

arkpar commented Jun 21, 2016

See #1365

nipunn1313 added a commit to nipunn1313/parity that referenced this issue Jul 4, 2016
@nipunn1313
Update sealing just once when externally importing many blocks
d7ccf99 
Fixes Issue openethereum#1372
@nipunn1313 nipunn1313 mentioned this issue Jul 4, 2016
Merged
nipunn1313 added a commit to nipunn1313/parity that referenced this issue Jul 5, 2016
@nipunn1313
Update sealing just once when externally importing many blocks
d88b8e0 
Fixes Issue openethereum#1372
nipunn1313 added a commit to nipunn1313/parity that referenced this issue Jul 6, 2016
@nipunn1313
Update sealing just once when externally importing many blocks
2e9277a 
Fixes Issue openethereum#1372
gavofyork pushed a commit that referenced this issue Jul 6, 2016
@nipunn1313 @gavofyork
Update sealing just once when externally importing many blocks (#1541)
4a9b9dc 
Fixes Issue #1372
@tomusdrw
Copy link
Collaborator

tomusdrw commented Jul 8, 2016

I think it can be closed thanks to #1541 ?

arkpar pushed a commit that referenced this issue Jul 11, 2016
@nipunn1313 @arkpar
Update sealing just once when externally importing many blocks (#1541)
b2b623d 
Fixes Issue #1372
gavofyork pushed a commit that referenced this issue Jul 12, 2016
@arkpar @gavofyork
Backport sealing fixes to beta (#1583)
ef124fa 
* Update sealing just once when  externally importing many blocks (#1541)

Fixes Issue #1372

* Fixing deadlock in miner (#1569)

* Fixing deadlock in miner
* Adding more comments
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
F7-optimisation 💊 An enhancement to provide better overall performance in terms of time-to-completion for a task.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gavofyork @tomusdrw @arkpar