chore: add logError for js worker call failures #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #160 +/- ##
=======================================
Coverage 94.31% 94.31%
=======================================
Files 68 68
Lines 1090 1090
Branches 302 301 -1
=======================================
Hits 1028 1028
Misses 57 57
Partials 5 5 ☔ View full report in Codecov by Sentry. |
varshamenon4
approved these changes
Feb 20, 2025
| @@ -26,6 +27,7 @@ export function workerPromiseForEventNames(eventNames, workerUrl) { | |||
| resolve(); | |||
| } else { | |||
| reject(e.data.error); | |||
| logError('workerPromiseForEventNames failed with the following error:', e.data.error); | |||
There was a problem hiding this comment.
Nice! I like how you include the error. Is there any other information that could be useful here when debugging?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TICKET: https://2u-internal.atlassian.net/browse/COSMO-637
Adds a "logError" that we will use to track failures when making request to the JS Worker for proctoring (i.e. with the Proctortrack software, as that's the only proctoring provider we use a JS Worker with).