Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adding link to username and email #444

Merged
merged 1 commit into from
Jan 28, 2025
Merged

fix: adding link to username and email #444

merged 1 commit into from
Jan 28, 2025

Conversation

kiram15
Copy link
Contributor

@kiram15 kiram15 commented Jan 24, 2025

Mimicking the functionality of the icon button to the right, we want to redirect people who click on a non-pending user's email or username to the learner information page (ex: https://localhost.stage.edx.org:18450/learner_information/[email protected])

Screen.Recording.2025-01-24.at.2.31.37.PM.mov

For testing:

  1. Go to the customers page and select a customer
  2. Scroll down to the associated learners table
  3. Test hyperlink on non-pending users
  4. Ensure hyperlink does not appear with pending users

Jira ticket

Copy link

codecov bot commented Jan 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.91%. Comparing base (afe3e47) to head (3e07ca4).
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #444      +/-   ##
==========================================
+ Coverage   84.33%   84.91%   +0.58%     
==========================================
  Files         185      185              
  Lines        3855     3859       +4     
  Branches      957      959       +2     
==========================================
+ Hits         3251     3277      +26     
+ Misses        581      564      -17     
+ Partials       23       18       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kiram15 kiram15 merged commit ea4506b into master Jan 28, 2025
6 checks passed
@kiram15 kiram15 deleted the kiram15/ENT-9882 branch January 28, 2025 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants