fix: style updates #162
Merged
fix: style updates #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #162 +/- ##
=======================================
Coverage 87.09% 87.09%
=======================================
Files 87 87
Lines 1712 1712
Branches 326 326
=======================================
Hits 1491 1491
Misses 211 211
Partials 10 10
Continue to review full report at Codecov.
|
DawoudSheraz
added
the
hacktoberfest-accepted
Ali-D-Akbar
approved these changes
Oct 7, 2021
| onClick={() => openHistoryModal()} | ||
| className="ml-1 my-2" |
There was a problem hiding this comment.
I think going for mr-1 mb-2 instead would be better for all the buttons. This way, it won't move the button from left and upwards.
| onClick={() => setResetPasswordModalIsOpen(true)} | ||
| className="ml-1 my-2" |
| @@ -29,6 +29,7 @@ export default function TogglePasswordStatus({ | |||
| id="toggle-password" | |||
| variant={`${passwordStatus.status === PASSWORD_STATUS.USABLE ? 'danger' : 'primary'}`} | |||
| onClick={() => setDisableUserModalIsOpen(true)} | |||
| className="ml-1 my-2" | |||
azanbinzahid
approved these changes
Oct 7, 2021
DawoudSheraz
force-pushed
the
dsheraz/PROD-2535
branch
from
f9630d1 to
71322cf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PROD-2535
Description
Other updates mentioned on PROD-2535 have been done in other PRs. While running on Safari, I didn't notice any style discrepancy, except the Account info table's rows border not going till the end.