fix the unit test issues

openedx · Jun 24, 2021 · 0eb1f74 · 0eb1f74
1 parent b6ca2e9
commit 0eb1f74
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/users/enrollments/Certificates.jsx b/src/users/enrollments/Certificates.jsx
@@ -27,7 +27,7 @@ export default function Certificates({
   const certificateRef = useRef(null);
 
   useEffect(() => {
-    if (certificate === undefined || (courseId !== oldCourseId)) {
+    if ((certificate === undefined && !displayCertErrors) || (courseId !== oldCourseId)) {
       getCertificate(username, courseId).then((result) => {
         const camelCaseResult = camelCaseObject(result);
         if (camelCaseResult.errors) {
@@ -40,7 +40,7 @@ export default function Certificates({
         }
       });
     }
-  });
+  }, [certificate, courseId]);
 
   useLayoutEffect(() => {
     if (certificateRef != null) {

diff --git a/src/users/enrollments/Certificates.test.jsx b/src/users/enrollments/Certificates.test.jsx
@@ -20,7 +20,7 @@ describe('Certificate component', () => {
 
   const props = {
     username: testUser,
-    courseKey: testCourseId,
+    courseId: testCourseId,
     closeHandler: jest.fn(() => {}),
   };
 
@@ -95,7 +95,7 @@ describe('Certificate component', () => {
     expect(dataRows.at(4).find('td').at(1).text()).toEqual('Not Available');
   });
 
-  it.skip('Certificate Fetch Errors', async () => {
+  it('Certificate Fetch Errors', async () => {
     apiMock = jest.spyOn(api, 'getCertificate').mockImplementationOnce(() => Promise.resolve({
       errors: [
         {