feat: hide level type and subjects field for masters courses #1000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ali-D-Akbar
force-pushed
the
aakbar/PROD-3254
branch
from
adbfeec to
6b58c8e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1000 +/- ##
=======================================
Coverage 68.04% 68.04%
=======================================
Files 129 129
Lines 3248 3248
Branches 943 920 -23
=======================================
Hits 2210 2210
Misses 993 993
Partials 45 45 ☔ View full report in Codecov by Sentry. |
|
Instead of hiding the fields altogether, make them optional in case some teams want to add the values. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PROD-3254
This PR puts Level Type and Primary Subject as non-marketable fields i.e. hide them for masters courses (and all the non-marketable courses)