-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: use shared browserslist config #495
Conversation
Codecov Report
@@ Coverage Diff @@
## master #495 +/- ##
=======================================
Coverage 60.37% 60.37%
=======================================
Files 45 45
Lines 795 795
Branches 146 146
=======================================
Hits 480 480
Misses 305 305
Partials 10 10 Continue to review full report at Codecov.
|
a6b81cd
to
dc7f492
Compare
Codecov Report
@@ Coverage Diff @@
## master #495 +/- ##
=======================================
Coverage 60.37% 60.37%
=======================================
Files 45 45
Lines 795 795
Branches 146 146
=======================================
Hits 480 480
Misses 305 305
Partials 10 10 Continue to review full report at Codecov.
|
Hmm, can/should these PRs also remove |
@adamstankiewicz might have a better idea about it. |
@Jawayria @davidjoy Let's keep I think it was a bit premature to assume we'd remove it earlier when I opened these PRs 😄 |
@adamstankiewicz es6 checks fail on browserslist-config PRs but these tests are passing if a new PR is created against master branch. |
Browserslist-config was added in a more recent PR. #649 |
REV-2122: As part of the Value Prop implementation, we are removing the course sock from Course Home
browserslist
configuration in favor of using a shared configuration.is-es5
check in CI since ES5 was only needed for IE 11 support which is dropped. The supported browsers defined by the shared configuration all natively support ES6.This change reduces the resultant asset bundle size.