Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Run npm audit fix to reduce vulnerabilities and fix tests #468

Merged
merged 2 commits into from
Dec 19, 2024

Conversation

feanil
Copy link
Contributor

@feanil feanil commented Dec 17, 2024

No description provided.

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.49%. Comparing base (3b25266) to head (b1aaac2).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #468   +/-   ##
=======================================
  Coverage   98.49%   98.49%           
=======================================
  Files          21       21           
  Lines        1261     1261           
  Branches       75       75           
=======================================
  Hits         1242     1242           
  Misses         19       19           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

We don't need to run in both chromeheadless and chrome with xvfb.
@feanil feanil requested a review from kdmccormick December 17, 2024 18:28
@feanil feanil changed the title chore: Run npm audit fix to reduce vulnerabilities. chore: Run npm audit fix to reduce vulnerabilities and fix tests Dec 17, 2024
Copy link
Member

@kdmccormick kdmccormick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much appreciated!

@kdmccormick kdmccormick merged commit e08a4c7 into master Dec 19, 2024
5 checks passed
@kdmccormick kdmccormick deleted the feanil/test_ci branch December 19, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants