-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added check to verify pip.txt installation #271
Conversation
Codecov Report
@@ Coverage Diff @@
## master #271 +/- ##
==========================================
+ Coverage 82.47% 82.68% +0.21%
==========================================
Files 21 21
Lines 1124 1138 +14
==========================================
+ Hits 927 941 +14
Misses 197 197
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a good start; can we also check that the updated pip-tools.txt is also reinstalled? I'd really also like a check that pip.txt is correctly utilized in any code that initializes an environment (like make requirements
and tox.ini
), but we probably need to manually make sure we can do that correctly in a few places before establishing a check for it.
@@ -18,6 +18,8 @@ piptools: | |||
|
|||
export CUSTOM_COMPILE_COMMAND = make upgrade | |||
upgrade: piptools ## update the requirements/*.txt files with the latest packages satisfying requirements/*.in | |||
pip-compile --allow-unsafe --rebuild --upgrade -o requirements/pip.txt requirements/pip.in | |||
pip install -qr requirements/pip.txt | |||
pip-compile --rebuild --upgrade -o requirements/pip_tools.txt requirements/pip_tools.in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we want to use the old, known-working pip and pip-tools conversation to update both pip.txt and pip-tools.txt, then reinstall packages from both updated files to try the new combination. So the pip.txt installation should be after the pip-tools.txt recompilation. The check above should also be updated accordingly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jmbowman I've updated the check, can you please have a look?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! We probably have a lot of repos that will need work to make this pass, even the edx-cookiecutters repo gets it wrong.
Yes you're right |
8530940
to
580a661
Compare
This check verifies that we are installing pip immediately after upgrading it.
pip should be installed after the upgrade to ensure that new pip version is compatible with installed pip-tools version.
JIRA: https://2u-internal.atlassian.net/browse/BOM-3402