-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: enzyme testing replaced by react tester #36159
Open
jciasenza
wants to merge
23
commits into
openedx:master
Choose a base branch
from
jciasenza:jci/issue35245
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+6,933
−11,307
Open
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
3a3b9b1
fix: enzyme testing replaced by react tester
jciasenza 7ff5004
fix: ESlint failures
jciasenza dc8557c
fix: remove enzyme dep and fix setupTest
jciasenza 16397a1
Merge branch 'master' into jci/issue35245
jciasenza 3cf6c79
Merge branch 'master' into jci/issue35245
jciasenza 3f800ad
Merge branch 'master' into jci/issue35245
jciasenza 60f6746
Merge branch 'master' into jci/issue35245
jciasenza 34b532e
Merge branch 'master' into jci/issue35245
jciasenza ac8f8a0
Merge branch 'master' into jci/issue35245
jciasenza 033c973
Merge branch 'master' into jci/issue35245
jciasenza 4fef66f
Merge branch 'master' into jci/issue35245
jciasenza 1a69f00
Merge branch 'master' into jci/issue35245
jciasenza b7f10bb
Merge branch 'master' into jci/issue35245
jciasenza f7a4847
Merge branch 'master' into jci/issue35245
jciasenza 4b0f48b
fix: enzyme testing replaced by react tester
jciasenza 9e9f55f
Merge branch 'openedx:master' into jci/issue35245
jciasenza 9ace7e8
Merge branch 'jci/issue35245' of https://github.com/jciasenza/edx-pla…
jciasenza 22320b2
fix: enzyme testing replaced by react tester
jciasenza 6dac593
fix: enzyme testing replaced by react tester
jciasenza 9b659e3
fix: enzyme testing replaced by react tester
jciasenza 6b855af
fix: enzyme testing replaced by react tester
jciasenza a757c7b
fix: enzyme testing replaced by react tester
jciasenza b68a54c
Merge branch 'master' into jci/issue35245
jciasenza File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
83 changes: 0 additions & 83 deletions
83
...tructor/static/instructor/ProblemBrowser/components/Main/__snapshots__/Main.test.jsx.snap
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems this test isn't quite living up to the "display dropdown on toggling dropdown" name.
The only
expect
I see in here is checking that before the user clicks thetoggleButton
'Some expected block name' doesn't appear on the screen.This should be updated to verify the dropdown is actually displayed when it is toggled.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check this out