Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BOM-1539 : Add python 3.8 to testing #45

Merged
merged 10 commits into from
Apr 30, 2020
Merged

BOM-1539 : Add python 3.8 to testing #45

merged 10 commits into from
Apr 30, 2020

Conversation

mzulqarnain1
Copy link
Contributor

@mzulqarnain1 mzulqarnain1 commented Apr 20, 2020 •
edited
Loading

Relevant JIRA : https://openedx.atlassian.net/browse/BOM-1539

  • Removed Python 2.7
  • Added Python 3.8 to testing
  • Removed Django versions < 2.2
  • Ran make upgrade
  • Fixed some quality failures

@mzulqarnain1 mzulqarnain1 marked this pull request as ready for review April 21, 2020 08:37
awais786
awais786 reviewed Apr 21, 2020
View reviewed changes
@awais786
Copy link
Contributor

@mzulqarnain1 in case of allow fails plz add new ticket for followup.

@openedx openedx deleted a comment from codecov bot Apr 21, 2020
@openedx openedx deleted a comment from codecov bot Apr 21, 2020
@mzulqarnain1 mzulqarnain1 mentioned this pull request Apr 21, 2020
Closed
UsamaSadiq
UsamaSadiq requested changes Apr 22, 2020
View reviewed changes
@openedx openedx deleted a comment from codecov bot Apr 22, 2020
@openedx openedx deleted a comment from codecov bot Apr 28, 2020
@openedx openedx deleted a comment from codecov bot Apr 28, 2020
morenol
morenol approved these changes Apr 29, 2020
View reviewed changes
Copy link

@morenol morenol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, my only concern is that this project doesn't have a changelog but that is unrelated to the purposes of this PR

jmbowman
jmbowman approved these changes Apr 29, 2020
View reviewed changes
@openedx openedx deleted a comment from codecov bot Apr 30, 2020
@openedx openedx deleted a comment from codecov bot Apr 30, 2020
@openedx openedx deleted a comment from codecov bot Apr 30, 2020
@openedx openedx deleted a comment from codecov bot Apr 30, 2020
@openedx openedx deleted a comment from codecov bot Apr 30, 2020
@openedx openedx deleted a comment from codecov bot Apr 30, 2020
@openedx openedx deleted a comment from codecov bot Apr 30, 2020
@mzulqarnain1 mzulqarnain1 merged commit 027c9b9 into master Apr 30, 2020
@mzulqarnain1 mzulqarnain1 deleted the zulqarnain/BOM-1539 branch April 30, 2020 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awais786 awais786 awais786 approved these changes

@jmbowman jmbowman jmbowman approved these changes

@morenol morenol morenol approved these changes

@UsamaSadiq UsamaSadiq UsamaSadiq approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mzulqarnain1 @awais786 @jmbowman @morenol @UsamaSadiq