fix(self-shutdown): abort frozen ios when unsharing shutdown nexus #1788
Conversation
These frozen IOs prevent the nexus from shutting down. We don't have any hooks today to do this whilsts the target is stopping so we add a simple loop which tries a number of times. Ideally we should get some sort of callback to trigger this. Signed-off-by: Tiago Castro <[email protected]>
tiagolobocastro
requested review from
dsavitskiy,
Abhinandan-Purkait,
abhilashshetty04 and
dsharma-dc
|
The frozen IOs are held up in our NexusChannel and not yet (re)submitted into the child device io channel, because in self shutdown path we haven't brought back io mode to normal. So wondering why they hold up nexus nvmf subsystem unshare/stop? Perhaps since the IOs have entered the nexus subsystem and not ack'ed? |
Haven't looked into the subsystem for a while but IIRC it wont stop because there's outstanding IO. When the last IO completes the subsystem is stopped. |
|
bors merge |
|
Build succeeded: |
These frozen IOs prevent the nexus from shutting down. We don't have any hooks today to do this whilsts the target is stopping so we add a simple loop which tries a number of times. Ideally we should get some sort of callback to trigger this.