-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(io-engine): use SafeMountIter instead of proc_mounts::MountIter #1591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bors try |
tryBuild failed: |
bors try |
tryBuild failed: |
bors try |
tryBuild failed: |
Requires #1590 |
This is what I alluded to during the standup, ideally we should not merge dependency PR's until the PR that makes use of it or a dummy handle PR is ready to merge here/control-plane |
bors-openebs-mayastor bot
pushed a commit
to openebs/mayastor-control-plane
that referenced
this pull request
Feb 20, 2024
749: refactor(csi-driver): replace MountIters with SafeMountIters r=niladrih a=niladrih Changes: - Replaces MountIters with SafeMountIters. Ref: - openebs/mayastor-dependencies#65 - openebs/mayastor#1591 Co-authored-by: Niladri Halder <[email protected]>
24b9463
to
a2dc269
Compare
bors try |
tryBuild succeeded: |
dsharma-dc
approved these changes
Feb 21, 2024
tiagolobocastro
approved these changes
Feb 21, 2024
c39dc97
to
b10e281
Compare
bors try |
tryBuild failed: |
bors try |
bors cancel |
tryBuild succeeded: |
Signed-off-by: Niladri Halder <[email protected]>
Ref: openebs/mayastor-dependencies#65 Signed-off-by: Niladri Halder <[email protected]>
bors try |
bors merge |
tryBuild succeeded: |
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Ref: