feat(volume/resize): don't allow volume resize for snapshot restore vols #777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsharma-dc
requested review from
tiagolobocastro,
Abhinandan-Purkait,
niladrih and
hrudaya21
dsharma-dc
changed the title
tiagolobocastro
approved these changes
Mar 8, 2024
…olume Signed-off-by: Diwakar Sharma <[email protected]>
dsharma-dc
force-pushed
the
clone_no_resize
branch
from
40d8815 to
9308b80
Compare
Abhinandan-Purkait
approved these changes
Mar 8, 2024
|
bors merge |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a volume is expanded after taking a snapshot or a restore created from that snapshot is expanded, then the IOs to the new io-units(block ranges) fails because the lba range falls out of bound for replica's parent device(snapshot). Till the issue is fixed, this check ensures we don't try to expand a volume if there is snapshot present. SPDK issue 3108.