Node labelling UX #726
Merged
Node labelling UX #726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiagolobocastro
force-pushed
the
label-openapi
branch
from
5890460 to
715b666
Compare
Namely fixes a bug related to path parsing with '=' Signed-off-by: Tiago Castro <[email protected]>
Signed-off-by: Tiago Castro <[email protected]>
PStor operations should use a specific type to allow for better expansion. Signed-off-by: Tiago Castro <[email protected]>
tiagolobocastro
force-pushed
the
label-openapi
branch
from
715b666 to
b2de839
Compare
tiagolobocastro
force-pushed
the
label-openapi
branch
2 times, most recently
from
289a8ef to
1b2128c
Compare
|
bors merge |
bors-openebs-mayastor bot
pushed a commit
that referenced
this pull request
Jan 29, 2024
726: Node labelling UX r=tiagolobocastro a=tiagolobocastro
❯ rest-plugin label node io-engine-1 openebs.io/performance=good
Node io-engine-1 labelled successfully. Current labels: {"openebs.io/performance": "good"}
❯ rest-plugin label node io-engine-1 openebs.io/performance=good
Node io-engine-1 not labelled as the label key already exists
❯ rest-plugin label node io-engine-1 openebs.io/performance=bad
Node io-engine-1 not labelled as the label key already exists, but with a different value and --overwrite is false
❯ rest-plugin label node io-engine-1 openebs.io/performance/also=good
Invalid label format: key can contain at most one / character
❯ rest-plugin label node io-engine-1 performance/=good
Invalid label format: both key and value parts must start with an ascii alphanumeric character
❯ rest-plugin label node io-engine-1 openebs.io/performance
Invalid label format: the supported formats are: key=value for adding (example: group=a) and key- for removing (example: group-)
❯ rest-plugin label node io-engine-1 openebs.io/performance-
Node io-engine-1 labelled successfully. Current labels: {}
❯ rest-plugin label node io-engine-1 openebs.io/performances-
Node io-engine-1 not unlabelled as it did not contain the label
---
refactor: apply python linter suggestions
Signed-off-by: Tiago Castro <[email protected]>
---
ci: check if python linter modified files
Signed-off-by: Tiago Castro <[email protected]>
---
ci: don't install pre-commit on CI
Signed-off-by: Tiago Castro <[email protected]>
---
refactor(node-label/api): doc the cli and openapi with key val
Expands the parsing of label on the cli and returns different error messages.
Splits the label into key and value.
todo: is this the right approach here, where should we do the validation?
kubectl seems to some validation, is there anything on the apiserver too?
Signed-off-by: Tiago Castro <[email protected]>
---
refactor(node-label): use specific types for store operations
PStor operations should use a specific type to allow for better expansion.
Signed-off-by: Tiago Castro <[email protected]>
---
docs(node-label/rest-plugin): improve ux for the command line
Signed-off-by: Tiago Castro <[email protected]>
---
build(openapi-generator): upgrade to v6.4.0
Namely fixes a bug related to path parsing with '='
Signed-off-by: Tiago Castro <[email protected]>
Co-authored-by: Tiago Castro <[email protected]>
|
Build failed: |
Expands the parsing of label on the cli and returns different error messages. Splits the label into key and value. todo: is this the right approach here, where should we do the validation? kubectl seems to some validation, is there anything on the apiserver too? Included a bunch of formatting changes due to bad formatted code being checked in... todo: run python linter on CI Updates openapi once again to get some ql error helpers. Signed-off-by: Tiago Castro <[email protected]>
Signed-off-by: Tiago Castro <[email protected]>
Signed-off-by: Tiago Castro <[email protected]>
Signed-off-by: Tiago Castro <[email protected]>
tiagolobocastro
force-pushed
the
label-openapi
branch
from
1b2128c to
5ee2ba4
Compare
|
bors merge |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❯ rest-plugin label node io-engine-1 openebs.io/performance=good
Node io-engine-1 labelled successfully. Current labels: {"openebs.io/performance": "good"}
❯ rest-plugin label node io-engine-1 openebs.io/performance=good
Node io-engine-1 not labelled as the label key already exists
❯ rest-plugin label node io-engine-1 openebs.io/performance=bad
Node io-engine-1 not labelled as the label already exists with different value
❯ rest-plugin label node io-engine-1 openebs.io/performance/also=good
Invalid node label: / is only allowed once
❯ rest-plugin label node io-engine-1 openebs.io/performance/=good
Invalid node label: / can only be used in the middle of the key
❯ rest-plugin label node io-engine-1 openebs.io/performance
Invalid node label: At least one label value is required
❯ rest-plugin label node io-engine-1 openebs.io/performance-
Node io-engine-1 labelled successfully. Current labels: {}
❯ rest-plugin label node io-engine-1 openebs.io/performances-
Node io-engine-1 not unlabelled as it did not contain the labe