fix(snapshot): scale volume with snapshot can go for replica rebuild

Signed-off-by: Hrudaya <[email protected]>
openebs · May 15, 2024 · 0f72cdd · 0f72cdd
1 parent 0167bc3
commit 0f72cdd
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 21 deletions.
diff --git a/control-plane/agents/src/bin/core/volume/specs.rs b/control-plane/agents/src/bin/core/volume/specs.rs
@@ -1034,9 +1034,7 @@ impl SpecOperationsHelper for VolumeSpec {
             }
 
             VolumeOperation::SetReplica(replica_count) => {
-                if self.has_snapshots() {
-                    Err(SvcError::NReplSnapshotNotAllowed {})
-                } else if *replica_count == self.num_replicas {
+                if *replica_count == self.num_replicas {
                     Err(SvcError::ReplicaCountAchieved {
                         id: self.uuid_str(),
                         count: self.num_replicas,

diff --git a/control-plane/agents/src/common/errors.rs b/control-plane/agents/src/common/errors.rs
@@ -336,12 +336,6 @@ pub enum SvcError {
         request: String,
         source: tonic::Status,
     },
-    #[snafu(display("Snapshots for multi-replica volumes are not allowed"))]
-    NReplSnapshotNotAllowed {},
-    #[snafu(display(
-        "Cannot create a multi-replica volume from a snapshot of a single-replica volume"
-    ))]
-    NReplSnapshotCloneCreationNotAllowed {},
     #[snafu(display("Replica's {} snapshot was unexpectedly skipped", replica))]
     ReplicaSnapSkipped { replica: String },
     #[snafu(display("Replica's {} snapshot was unexpectedly not taken", replica))]
@@ -951,18 +945,6 @@ impl From<SvcError> for ReplyError {
                 source,
                 extra,
             },
-            SvcError::NReplSnapshotNotAllowed {} => ReplyError {
-                kind: ReplyErrorKind::InvalidArgument,
-                resource: ResourceKind::VolumeSnapshot,
-                source,
-                extra,
-            },
-            SvcError::NReplSnapshotCloneCreationNotAllowed {} => ReplyError {
-                kind: ReplyErrorKind::InvalidArgument,
-                resource: ResourceKind::VolumeSnapshotClone,
-                source,
-                extra,
-            },
             SvcError::ReplicaSnapSkipped { .. } => ReplyError {
                 kind: ReplyErrorKind::Aborted,
                 resource: ResourceKind::VolumeSnapshot,