Handle theme assets cache burst (fix #761) #781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidbgk
suggested changes
Feb 19, 2017
udata/theme.py
Outdated
| burst = pkg_resources.get_distribution(current.pkg_version).version | ||
| else: | ||
| burst = current.version | ||
| return '?'.join((url, '_={0}'.format(burst))) |
There was a problem hiding this comment.
Why not '{url}?_={burst}'.format(url=url, burst=burst)?
| def theme_static_with_version(ctx, filename, external=False): | ||
| '''Override the default theme static to add cache burst''' | ||
| url = global_theme_static(ctx, filename, external=external) | ||
| if url.endswith('/'): # this is a directory, no need for cache burst |
There was a problem hiding this comment.
davidbgk
approved these changes
Feb 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensure theme assets have a proper cache burst which can be optionnaly extracted from the package version.