Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable ES timeouts #2265

Merged
merged 5 commits into from
Jul 30, 2019
Merged

Configurable ES timeouts #2265

merged 5 commits into from
Jul 30, 2019

Conversation

noirbizarre
Copy link
Contributor

@noirbizarre noirbizarre commented Jul 30, 2019

This PR makes the Elasticsearch timeouts configurable through:

  • ELASTICSEARCH_TIMEOUT as default/read/query timeout
  • ELASTICSEARCH_INDEX_TIMEOUT as indexing/write timeout (longuer timeout)
  • the -t/--timeout in udata search index command (overrides ELASTICSEARCH_INDEX_TIMEOUT if provided)

This allows to improve control over timeout and so will allows to handle indexing errors such as:

elasticsearch.exceptions.ConnectionTimeout: ConnectionTimeout caused by - ReadTimeoutError(HTTPConnectionPool(host=u'localhost', port=9200): Read timed out. (read timeout=10))

Possible improvement: do the same for retry policy

@noirbizarre noirbizarre requested a review from a team July 30, 2019 09:25
@noirbizarre noirbizarre merged commit 896310d into opendatateam:master Jul 30, 2019
@noirbizarre noirbizarre deleted the es-timeouts branch July 30, 2019 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant