Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix discussions UI #2190

Merged
merged 18 commits into from
Jul 23, 2019
Merged

fix discussions UI #2190

merged 18 commits into from
Jul 23, 2019

Conversation

taniki
Copy link
Contributor

@taniki taniki commented Jun 6, 2019 •
edited
Loading

  • glitch when message is short
  • missing pagination
  • restore deep links
  • substitute ad-hoc js code to swagger.js model

FIX #2061

UI

image

@taniki taniki changed the title fix discussions [wip] fix discussions Jun 6, 2019
@taniki
Copy link
Contributor Author

taniki commented Jun 6, 2019

deeplinks are kind of broken but I have no easy fix right now.

@taniki taniki changed the title [wip] fix discussions fix discussions Jun 6, 2019
@taniki
Copy link
Contributor Author

taniki commented Jun 6, 2019 •
edited
Loading

SOLVE #2061

@taniki taniki requested a review from a team June 10, 2019 10:22
abulte
abulte reviewed Jun 11, 2019
View reviewed changes
js/components/discussions/threads.vue Outdated Show resolved Hide resolved
js/components/discussions/threads.vue Outdated Show resolved Hide resolved
@abulte abulte changed the title fix discussions WIP: fix discussions Jun 21, 2019
@taniki
Copy link
Contributor Author

taniki commented Jul 11, 2019

cf description. I have given some thoughts about this part of UI and pagination will be better on top.

@taniki
Copy link
Contributor Author

taniki commented Jul 11, 2019

Removing the "part of organisation" badge. Opening an issue about API and feasibility for later.

@taniki taniki requested a review from abulte July 11, 2019 14:16
@taniki taniki changed the title WIP: fix discussions fix discussions UI Jul 11, 2019
@taniki taniki requested review from a team and removed request for abulte July 11, 2019 14:25
abulte
abulte approved these changes Jul 11, 2019
View reviewed changes
js/components/discussions/threads.vue Outdated Show resolved Hide resolved
js/components/discussions/threads.vue Outdated Show resolved Hide resolved
js/components/discussions/threads.vue Outdated Show resolved Hide resolved
@taniki taniki merged commit 9262b14 into opendatateam:master Jul 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abulte abulte abulte approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Paginate discussions on frontend
2 participants
@taniki @abulte