Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resources modals consistency #1846

Merged
merged 4 commits into from
Aug 23, 2018
Merged

Resources modals consistency #1846

merged 4 commits into from
Aug 23, 2018

Conversation

noirbizarre
Copy link
Contributor

@noirbizarre noirbizarre commented Aug 23, 2018

This PR adds some consistency to the resources modals:

Only show save button when form is shown

The "Add resource" modal "Save" button is only shown when the form is shown too, this prevent form validation when the form isn't present yet.

Before

screenshot-www data gouv fr-2018 08 23-14-40-42

After

screenshot-data xps-2018 08 23-17-07-27

Wide modal when editing

The modal become wide when the form shown:

  • prevent most fields from spanning on 2 lines
  • allow form to fill in the page and avoid scrolling to see buttons

Description fields has also been reduced from 6 to 3 lines

Before

screenshot-www data gouv fr-2018 08 23-17-04-30

After

screenshot-data xps-2018 08 23-17-03-20

Same buttons design and order

Both modals have now the buttons design and order: Cancel buttons is on the left and smaller, actions on the right, outlined

Before

Add modal

screenshot-www data gouv fr-2018 08 23-17-11-45

Edit modal

screenshot-www data gouv fr-2018 08 23-17-13-14

After

Add modal

screenshot-data xps-2018 08 23-17-14-30

Edit modal

screenshot-data xps-2018 08 23-17-15-58

@noirbizarre noirbizarre added this to the 1.5.3 milestone Aug 23, 2018
@noirbizarre noirbizarre self-assigned this Aug 23, 2018
@noirbizarre noirbizarre requested a review from a team August 23, 2018 12:43
@noirbizarre noirbizarre changed the title Show add resource modal save button with the form Resources modals consistency Aug 23, 2018
@noirbizarre noirbizarre merged commit fb499b7 into opendatateam:1.5 Aug 23, 2018
@noirbizarre noirbizarre deleted the add-resource-save-button branch August 23, 2018 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants