show message for emtpy dataset search [FIX #1044] #1284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
taniki
commented
Nov 29, 2017
taniki
commented
noirbizarre
previously requested changes
Nov 29, 2017
udata/templates/dataset/list.html
Outdated
| @@ -15,12 +15,16 @@ | |||
|
|
|||
| {% block breadcrumb %} | |||
| <li class="active"> | |||
| {{ _('Datasets') }} | |||
| {% if datasets.total == 0 %} | |||
There was a problem hiding this comment.
Even if there is no results, the breadcrum should be Datasets.
udata/templates/dataset/list.html
Outdated
| {% if datasets.total == 0 %} | ||
| <small>{{ _('No dataset') }}</small> | ||
| {% else %} | ||
| {{ _('Datasets') }} | ||
| <small>{{ _('%(start)s to %(end)s on %(total)s', |
There was a problem hiding this comment.
But the paging details can be hidden instead
udata/templates/dataset/list.html
Outdated
| @@ -43,7 +47,15 @@ | |||
|
|
|||
| {% block main_content %} | |||
| <div class="row"> | |||
| <div class="col-md-8 col-lg-9 smaller"> | |||
|
|
|||
| {% if not datasets %} | |||
There was a problem hiding this comment.
Express the opposite, it should be clearer: if datasets ... else ... (positive condition and nominal case first)
|
squashed and ready. it should also fix the messed up indenting |
|
related to #1044 |
abulte
approved these changes
Dec 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.