Dockerfile: use fixed vllm-provided nccl version #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtrifiro
requested review from
z103cb
and removed request for
heyselbi and
rpancham
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dtrifiro, z103cb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 3f5757e
into
opendatahub-io:ibm_main
3 checks passed
Merged
z103cb
pushed a commit
to z103cb/opendatahub_vllm
that referenced
this pull request
May 16, 2024
…ubi (opendatahub-io#23) Changes: - vLLM v0.4.2 was published today, update our build to use pre-built libs from their wheel - bump other dependencies in the image build (base UBI image, miniforge, flash attention, grpcio-tools, accelerate) - little cleanup to remove `PYTORCH_` args that are no longer used --------- Signed-off-by: Travis Johnson <[email protected]>
z103cb
pushed a commit
to z103cb/opendatahub_vllm
that referenced
this pull request
May 16, 2024
…ubi (opendatahub-io#23) Changes: - vLLM v0.4.2 was published today, update our build to use pre-built libs from their wheel - bump other dependencies in the image build (base UBI image, miniforge, flash attention, grpcio-tools, accelerate) - little cleanup to remove `PYTORCH_` args that are no longer used --------- Signed-off-by: Travis Johnson <[email protected]>
prarit
pushed a commit
to prarit/vllm
that referenced
this pull request
Oct 18, 2024
Removed HIP specific matvec logic that is duplicated from tuned_gemm.py and doesn't support bf16
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nccl, which is install> 2.18 has a bug which greatly increases memory overhead, thus a specific nccl version has to be installed
See NVIDIA/nccl#1234 and vllm-project/vllm-nccl#1