Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tokenize endpoint #54

Merged
merged 2 commits into from
Jul 22, 2024
Merged

Fix tokenize endpoint #54

merged 2 commits into from
Jul 22, 2024

Conversation

njhill
Copy link
Contributor

@njhill njhill commented Jul 22, 2024

Fixes to the tokenization endpoint, missed during recent LoRA-related fixes.

@codecov-commenter
Copy link

codecov-commenter commented Jul 22, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 62.96%. Comparing base (fc6d899) to head (0efa312).

Files Patch % Lines
src/vllm_tgis_adapter/grpc/validation.py 33.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #54      +/-   ##
==========================================
- Coverage   63.03%   62.96%   -0.07%     
==========================================
  Files          18       18              
  Lines        1285     1288       +3     
  Branches      228      229       +1     
==========================================
+ Hits          810      811       +1     
- Misses        398      399       +1     
- Partials       77       78       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@njhill njhill requested a review from dtrifiro July 22, 2024 15:32
@dtrifiro dtrifiro added this pull request to the merge queue Jul 22, 2024
@dtrifiro dtrifiro removed this pull request from the merge queue due to a manual request Jul 22, 2024
@dtrifiro dtrifiro added this pull request to the merge queue Jul 22, 2024
@dtrifiro dtrifiro removed this pull request from the merge queue due to a manual request Jul 22, 2024
@dtrifiro dtrifiro enabled auto-merge July 22, 2024 16:36
@dtrifiro dtrifiro added this pull request to the merge queue Jul 22, 2024
Merged via the queue into main with commit 0f7df61 Jul 22, 2024
3 checks passed
@dtrifiro dtrifiro deleted the fix-tokenize branch July 22, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants