Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create socket before starting the engine and pass socket into the vllm server on startup #233

Merged
merged 1 commit into from
Feb 24, 2025

Conversation

jberkhahn
Copy link
Contributor

VLLM made a breaking change recently here: vllm-project/vllm#13113

But it looks like they've been doing stuff around passing that socket in for a while to avoid some stuff like race conditions? Figured I'd port over the functionality and get it on vllm version.

@jberkhahn jberkhahn force-pushed the http_sock branch 3 times, most recently from 33065c1 to 35fd429 Compare February 21, 2025 22:59
@codecov-commenter
Copy link

codecov-commenter commented Feb 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.46%. Comparing base (197f101) to head (a25711b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #233      +/-   ##
==========================================
+ Coverage   63.26%   63.46%   +0.19%     
==========================================
  Files          28       28              
  Lines        1764     1768       +4     
  Branches      218      219       +1     
==========================================
+ Hits         1116     1122       +6     
+ Misses        542      541       -1     
+ Partials      106      105       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dtrifiro dtrifiro enabled auto-merge February 24, 2025 09:51
@dtrifiro dtrifiro added this pull request to the merge queue Feb 24, 2025
@dtrifiro
Copy link
Contributor

Thanks, looks good.

Merged via the queue into opendatahub-io:main with commit 178d4ba Feb 24, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants