Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagate cancellation of gRPC requests #130

Merged
merged 2 commits into from
Sep 23, 2024
Merged

Propagate cancellation of gRPC requests #130

merged 2 commits into from
Sep 23, 2024

Conversation

njhill
Copy link
Contributor

@njhill njhill commented Sep 16, 2024

@dtrifiro added a partial change for this while ago which was reverted to maintain compatibility with older vLLM version.

@njhill njhill requested a review from dtrifiro September 16, 2024 16:53
@codecov-commenter
Copy link

codecov-commenter commented Sep 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.94%. Comparing base (20db20b) to head (e7d17dc).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #130      +/-   ##
==========================================
+ Coverage   55.64%   56.94%   +1.30%     
==========================================
  Files          24       25       +1     
  Lines        1488     1533      +45     
  Branches      269      277       +8     
==========================================
+ Hits          828      873      +45     
+ Misses        583      582       -1     
- Partials       77       78       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dtrifiro dtrifiro merged commit 40e6e1d into main Sep 23, 2024
2 of 3 checks passed
@dtrifiro dtrifiro deleted the cancellation branch September 23, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants