Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

concurrent http and grpc #12

Merged
merged 5 commits into from
Jun 20, 2024
Merged

concurrent http and grpc #12

merged 5 commits into from
Jun 20, 2024

Conversation

dtrifiro
Copy link
Contributor

  • Revert "✨ add ability to run REST with grpc server"
  • start http and grpc server concurrently

@prashantgupta24 prashantgupta24 mentioned this pull request Jun 19, 2024
Closed
3 tasks
@prashantgupta24 prashantgupta24 self-requested a review June 19, 2024 18:30
@prashantgupta24 prashantgupta24 marked this pull request as ready for review June 19, 2024 18:31
@prashantgupta24 prashantgupta24 added this pull request to the merge queue Jun 19, 2024
@prashantgupta24 prashantgupta24 removed this pull request from the merge queue due to a manual request Jun 19, 2024
@prashantgupta24
Copy link
Contributor

I figured no point in merging since I don't know how to release to pypi anyway

@dtrifiro dtrifiro force-pushed the concurrent-http-and-grpc branch 2 times, most recently from f861021 to 3ec9cef Compare June 20, 2024 11:21
@dtrifiro dtrifiro force-pushed the concurrent-http-and-grpc branch 3 times, most recently from 7dec913 to d1479e8 Compare June 20, 2024 13:00
@dtrifiro dtrifiro enabled auto-merge June 20, 2024 13:02
@dtrifiro dtrifiro added this pull request to the merge queue Jun 20, 2024
@dtrifiro dtrifiro removed this pull request from the merge queue due to a manual request Jun 20, 2024
@dtrifiro dtrifiro merged commit 1d34d8f into main Jun 20, 2024
1 check passed
@dtrifiro dtrifiro deleted the concurrent-http-and-grpc branch June 20, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prashantgupta24 prashantgupta24 prashantgupta24 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dtrifiro @prashantgupta24