Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: more permission need for dashboard for consolelink #1586

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

zdtsw
Copy link
Member

@zdtsw zdtsw commented Jan 29, 2025

  • cleanup duplicated one

Description

{"level":"error","ts":"2025-01-29T13:54:17Z","msg":"Failed to execute action","controller":"dashboard","controllerGroup":"components.platform.opendatahub.io","controllerKind":"Dashboard","Dashboard":{"name":"default-dashboard"},"namespace":"","name":"default-dashboard","reconcileID":"7a6f42d0-9e03-4b2a-9172-0fe72aa97084","action":"github.com/opendatahub-io/opendatahub-operator/v2/pkg/controller/actions/deploy.(*Action).run-fm","error":"failed to remove owner references from object /rhodslink with gvk console.openshift.io/v1, Kind=ConsoleLink: consolelinks.console.openshift.io \"rhodslink\" is forbidden: User \"system:serviceaccount:redhat-ods-operator:redhat-ods-operator-controller-manager\" cannot update resource \"consolelinks\" in API group \"console.openshift.io\" at the cluster scope","stacktrace":"github.com/opendatahub-io/opendatahub-operator/v2/pkg/controller/reconciler.

https://issues.redhat.com/browse/RHOAIENG-18859

How Has This Been Tested?

Screenshot or short clip

Merge criteria

  • You have read the contributors guide.
  • Commit messages are meaningful - have a clear and concise summary and detailed explanation of what was changed and why.
  • Pull Request contains a description of the solution, a link to the JIRA issue, and to any dependent or related Pull Request.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@openshift-ci openshift-ci bot requested review from CFSNM and gzaronikas January 29, 2025 14:06
@zdtsw zdtsw requested review from lburgazzoli and VaishnaviHire and removed request for gzaronikas January 29, 2025 14:06
@zdtsw zdtsw changed the title fix: more permission need for dashbaord for consolelink fix: more permission need for dashboard for consolelink Jan 29, 2025
- cleanup duplicated one

Signed-off-by: Wen Zhou <[email protected]>
Copy link
Member

@CFSNM CFSNM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx @zdtsw for the quic fix!

Copy link

openshift-ci bot commented Jan 29, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CFSNM, lburgazzoli, ykaliuta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [CFSNM,lburgazzoli,ykaliuta]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Jan 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 19.98%. Comparing base (6e134b1) to head (64fefca).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1586   +/-   ##
=======================================
  Coverage   19.98%   19.98%           
=======================================
  Files         159      159           
  Lines       10780    10780           
=======================================
  Hits         2154     2154           
  Misses       8396     8396           
  Partials      230      230           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@openshift-merge-bot openshift-merge-bot bot merged commit 90a78ea into opendatahub-io:main Jan 29, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants