Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sync]fix: missing permission to update prometheusrules #1584

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

zdtsw
Copy link
Member

@zdtsw zdtsw commented Jan 29, 2025

(cherry picked from commit fd4c11b)
sync #1581

Description

https://issues.redhat.com/browse/RHOAIENG-18913

How Has This Been Tested?

Screenshot or short clip

Merge criteria

  • You have read the contributors guide.
  • Commit messages are meaningful - have a clear and concise summary and detailed explanation of what was changed and why.
  • Pull Request contains a description of the solution, a link to the JIRA issue, and to any dependent or related Pull Request.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Signed-off-by: Wen Zhou <[email protected]>
(cherry picked from commit fd4c11b)
Signed-off-by: Wen Zhou <[email protected]>
@zdtsw zdtsw added the rhoai label Jan 29, 2025
@openshift-ci openshift-ci bot requested review from lburgazzoli and lphiri January 29, 2025 11:29
@zdtsw zdtsw requested review from jiripetrlik and VaishnaviHire and removed request for lphiri January 29, 2025 11:29
Copy link

openshift-ci bot commented Jan 29, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lburgazzoli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Jan 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 20.33%. Comparing base (1feefd3) to head (426c048).
Report is 1 commits behind head on rhoai.

Additional details and impacted files
@@           Coverage Diff           @@
##            rhoai    #1584   +/-   ##
=======================================
  Coverage   20.33%   20.33%           
=======================================
  Files         161      161           
  Lines       11014    11014           
=======================================
  Hits         2240     2240           
  Misses       8534     8534           
  Partials      240      240           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zdtsw zdtsw merged commit 3b3a3d9 into opendatahub-io:rhoai Jan 29, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants