Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow to restore archived runs whose associate experiments are archived #3757

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pnaik1
Copy link
Contributor

@pnaik1 pnaik1 commented Feb 12, 2025

https://issues.redhat.com/browse/RHOAIENG-17134

Description

Allow the archived runs to restore when associated experiments are archived

https://www.figma.com/proto/etbN0ccCcZR1qKCpJXQNAg/Pipeline-phase-2?page-id=12031%3A86470&node-id=14283-127776&viewport=865%2C2037%2C0.08&t=1mf6n88oVojaNlPi-1&scaling=scale-down-width&content-scaling=fixed&starting-point-node-id=14283%3A128060

https://www.figma.com/proto/etbN0ccCcZR1qKCpJXQNAg/Pipeline-phase-2?page-id=12031%3A86470&node-id=14283-128386&viewport=865%2C2037%2C0.08&t=U6y6jJguHHmIlsyk-1&scaling=min-zoom&content-scaling=fixed&starting-point-node-id=14283%3A128079

Screen.Recording.2025-02-12.at.6.49.50.PM.mov
Screen.Recording.2025-02-12.at.6.51.42.PM.mov

How Has This Been Tested?

  1. Archive a experiment
  2. Try to bulk restore the archived runs associated with archived experiment from the Runs nav
  3. Do the step for single archived runs

Test Impact

WIP: cypress test

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress This PR is in WIP state label Feb 12, 2025
Copy link
Contributor

openshift-ci bot commented Feb 12, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign manosnoam for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pnaik1 pnaik1 changed the title [WIP] allow to restore archived runs whose associate experiments are archived allow to restore archived runs whose associate experiments are archived Feb 13, 2025
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress This PR is in WIP state label Feb 13, 2025
Copy link

codecov bot commented Feb 13, 2025

Codecov Report

Attention: Patch coverage is 95.96774% with 10 lines in your changes missing coverage. Please review.

Project coverage is 84.41%. Comparing base (05a3f3c) to head (53c76e2).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
.../concepts/pipelines/content/useRestoreStatuses.tsx 92.18% 5 Missing ⚠️
...bal/runs/RestoreRunWithArchivedExperimentModal.tsx 96.49% 2 Missing ⚠️
...es/content/tables/pipelineRun/PipelineRunTable.tsx 96.00% 1 Missing ⚠️
...es/pipelines/global/runs/RestoreRunsStatusIcon.tsx 90.00% 1 Missing ⚠️
frontend/src/pages/pipelines/global/runs/utils.ts 97.50% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3757      +/-   ##
==========================================
+ Coverage   84.34%   84.41%   +0.07%     
==========================================
  Files        1486     1493       +7     
  Lines       34050    34311     +261     
  Branches     9438     9497      +59     
==========================================
+ Hits        28719    28964     +245     
- Misses       5331     5347      +16     
Files with missing lines Coverage Δ
...nd/src/concepts/dashboard/DashboardModalFooter.tsx 100.00% <100.00%> (ø)
...content/tables/pipelineRun/PipelineRunTableRow.tsx 91.93% <100.00%> (+1.19%) ⬆️
...bles/pipelineRun/PipelineRunTableRowExperiment.tsx 100.00% <100.00%> (ø)
...ines/global/runs/RestoreRunsTableRowExperiment.tsx 100.00% <100.00%> (ø)
...es/global/runs/RunsWithArchivedExperimentTable.tsx 100.00% <100.00%> (ø)
frontend/src/pages/pipelines/global/runs/types.ts 100.00% <ø> (ø)
frontend/src/utilities/allSettledPromises.ts 100.00% <100.00%> (ø)
...es/content/tables/pipelineRun/PipelineRunTable.tsx 90.90% <96.00%> (+0.52%) ⬆️
...es/pipelines/global/runs/RestoreRunsStatusIcon.tsx 90.00% <90.00%> (ø)
frontend/src/pages/pipelines/global/runs/utils.ts 97.50% <97.50%> (ø)
... and 2 more

... and 19 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05a3f3c...53c76e2. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants