-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
created ilab form #3756
base: main
Are you sure you want to change the base?
created ilab form #3756
Conversation
frontend/src/pages/pipelines/global/modelCustomization/ModelCustomization.tsx
Outdated
Show resolved
Hide resolved
frontend/src/pages/pipelines/global/modelCustomization/ModelCustomization.tsx
Outdated
Show resolved
Hide resolved
b25c332
to
2baba8d
Compare
7fe40a8
to
ae9658a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great just one small request (☞ຈل͜ຈ)☞
frontend/src/pages/pipelines/GlobalModelCustomizationRoutes.tsx
Outdated
Show resolved
Hide resolved
frontend/src/pages/pipelines/global/modelCustomization/FineTunePageFooter.tsx
Outdated
Show resolved
Hide resolved
I made it so |
everything should be good now |
frontend/src/pages/pipelines/global/modelCustomization/ModelCustomizationForm.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: DaoDaoNoCode The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
RHOAIENG-19020
Description
Added the instruct lab form with some zod methods.
The base URL is
/modelCustomization/instructlab/<project-name>
How Has This Been Tested?
Added test files. You can also test visually.
Test Impact
Added tests.
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main