Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

created ilab form #3756

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

created ilab form #3756

wants to merge 1 commit into from

Conversation

rsun19
Copy link
Contributor

@rsun19 rsun19 commented Feb 11, 2025

RHOAIENG-19020

Description

Added the instruct lab form with some zod methods.

The base URL is /modelCustomization/instructlab/<project-name>

Screenshot 2025-02-11 at 5 34 53 PM

How Has This Been Tested?

Added test files. You can also test visually.

Test Impact

Added tests.

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • [ x Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@rsun19
Copy link
Contributor Author

rsun19 commented Feb 11, 2025

Screenshot 2025-02-11 at 5 36 40 PM

I experienced these errors when trying to call api.listPipelines({}) and api.listPipelineVersions({}, pipeline.pipeline_id,), can someone look into them? The first two error messages are related to the former, and the last one refers to the latter. Everything works, but these errors appear for some reason.

@rsun19 rsun19 changed the title created ilab form [wip] created ilab form Feb 11, 2025
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress This PR is in WIP state label Feb 11, 2025
Copy link

codecov bot commented Feb 11, 2025

Codecov Report

Attention: Patch coverage is 64.48598% with 38 lines in your changes missing coverage. Please review.

Project coverage is 84.32%. Comparing base (8c2a737) to head (7b722d9).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...rm/modelCustomizationFormSchema/validationUtils.ts 25.00% 24 Missing ⚠️
...s/global/modelCustomization/FineTunePageFooter.tsx 45.45% 6 Missing ⚠️
...obal/modelCustomization/ModelCustomizationForm.tsx 78.57% 3 Missing ⚠️
.../content/modelCustomizationForm/useIlabPipeline.ts 86.66% 2 Missing ⚠️
...c/concepts/pipelines/apiHooks/usePipelineByName.ts 88.88% 1 Missing ⚠️
...ages/pipelines/global/GlobalPipelineCoreLoader.tsx 80.00% 1 Missing ⚠️
...end/src/routes/pipelines/modelCustomizationForm.ts 75.00% 1 Missing ⚠️

❌ Your patch check has failed because the patch coverage (64.48%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3756      +/-   ##
==========================================
- Coverage   84.35%   84.32%   -0.03%     
==========================================
  Files        1485     1496      +11     
  Lines       34063    34183     +120     
  Branches     9437     9470      +33     
==========================================
+ Hits        28733    28824      +91     
- Misses       5330     5359      +29     
Files with missing lines Coverage Δ
frontend/src/api/pipelines/custom.ts 95.83% <100.00%> (+0.08%) ⬆️
frontend/src/components/EmptyStateErrorMessage.tsx 100.00% <100.00%> (+85.71%) ⬆️
...mizationForm/modelCustomizationFormSchema/types.ts 100.00% <100.00%> (ø)
.../concepts/pipelines/context/usePipelineAPIState.ts 100.00% <ø> (ø)
...pages/pipelines/GlobalModelCustomizationRoutes.tsx 100.00% <ø> (ø)
.../pages/pipelines/global/PipelineCoreNoProjects.tsx 100.00% <ø> (+75.00%) ⬆️
...pelines/global/modelCustomization/FineTunePage.tsx 100.00% <100.00%> (ø)
...pages/pipelines/global/modelCustomization/const.ts 100.00% <100.00%> (ø)
...c/concepts/pipelines/apiHooks/usePipelineByName.ts 88.88% <88.88%> (ø)
...ages/pipelines/global/GlobalPipelineCoreLoader.tsx 90.00% <80.00%> (+21.25%) ⬆️
... and 5 more

... and 9 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c2a737...7b722d9. Read the comment docs.

@rsun19 rsun19 force-pushed the ilab-form branch 9 times, most recently from b25c332 to 2baba8d Compare February 14, 2025 15:03
@rsun19 rsun19 changed the title [wip] created ilab form created ilab form Feb 14, 2025
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress This PR is in WIP state label Feb 14, 2025
@rsun19 rsun19 force-pushed the ilab-form branch 2 times, most recently from 7fe40a8 to ae9658a Compare February 14, 2025 15:40
Copy link
Member

@Gkrumbach07 Gkrumbach07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great just one small request (☞ຈل͜ຈ)☞

@rsun19
Copy link
Contributor Author

rsun19 commented Feb 14, 2025

I made it so /modelCustomization/instructlab/ links to 404

@rsun19 rsun19 changed the title created ilab form [wip] created ilab form Feb 14, 2025
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress This PR is in WIP state label Feb 14, 2025
@rsun19 rsun19 changed the title [wip] created ilab form created ilab form Feb 14, 2025
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress This PR is in WIP state label Feb 14, 2025
@rsun19
Copy link
Contributor Author

rsun19 commented Feb 14, 2025

everything should be good now

Copy link
Member

@DaoDaoNoCode DaoDaoNoCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

openshift-ci bot commented Feb 14, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: DaoDaoNoCode
Once this PR has been reviewed and has the lgtm label, please ask for approval from gkrumbach07. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants