Address github.com/pkg/sftp Denial of Service (DoS) #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jooho <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Jooho The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
it turned out that the build issue only happened with release-0.11.1 so I created another PR (#268) |
|
/retest |
openshift-merge-bot
bot
merged commit aa97175
into
opendatahub-io:release-0.11.1
5 checks passed
VedantMahabaleshwarkar
pushed a commit
to VedantMahabaleshwarkar/modelmesh-serving
that referenced
this pull request
Apr 26, 2024
* Add PVC support Add PVC support according to the design and discussions captured in the issue, kserve#230 Signed-off-by: Chin Huang <[email protected]> * add predictor controller login Signed-off-by: Chin Huang <[email protected]> * code restructure, cleanup based on review Signed-off-by: Chin Huang <[email protected]> * fix addPullerSidecar to include all pvcs Signed-off-by: Chin Huang <[email protected]> * restructure and simplify code, use global configmap rather than env var Signed-off-by: Chin Huang <[email protected]> * make AllowAnyPVC dynamic, update docs Signed-off-by: Chin Huang <[email protected]> * add runtimeSupportsPredictor check Signed-off-by: Chin Huang <[email protected]> * use PredictorRegistry and add storage to find() Signed-off-by: Chin Huang <[email protected]> --------- Signed-off-by: Chin Huang <[email protected]>
VedantMahabaleshwarkar
pushed a commit
to VedantMahabaleshwarkar/modelmesh-serving
that referenced
this pull request
Apr 26, 2024
Motivation Address PVC follow-up work items outlined in kserve#337 for PVC storage introduced in opendatahub-io#267 Modifications Code changes: - Sort PVC mounts on serving runtime specs to avoid unstable repeated runtime rollouts as Kubernetes treat two otherwise identical deployment specs as different if the same set of volume mounts are in different order - Don't add non-existent PVCs from predictor/ISVC when allowAnyPVC is enabled as this would cause all serving pods for that runtime to stay in - Pending state with unbound (pending) volumes - Tolerate missing storage-config secret when allowAnyPVC is enabled - Lint: fix "io/ioutil" deprecations FVT changes: - Add Storage test suite - Add helper methods to add PVC to storage-config during FVT - Allow for additional time in WaitForReadyDeployStatus but allow early abort on success - Check if pod still running before gRPC/REST requests, reconnect if necessary - Only choose "Ready" runtime pod for port-forwards - Include ISVC tests in Predictor test suite to ensure "serial" execution of TLS tests Resolves kserve#337 Signed-off-by: Christian Kadner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address github.com/pkg/sftp Denial of Service (DoS)
https://app.snyk.io/vuln/SNYK-GOLANG-GITHUBCOMPKGSFTP-569475
Motivation
Modifications
Result
PR checklist
Checklist items below are applicable for development targeted to both fast and stable branches/tags
Checklist items below are applicable for development targeted to both fast and stable branches/tags