Apply patch to remove empty string of caBundle #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vaibhav Jain <[email protected]>
openshift-ci
bot
requested review from
danielezonca and
VedantMahabaleshwarkar
|
/retest |
|
This PR is depends on opendatahub-io/opendatahub-operator#804 |
|
/retest |
|
/test pr-image-mirror |
davidesalerno
approved these changes
Jan 17, 2024
Well spotted, one of the question I had during 2.5 certification was indeed why KServe has no issue and this is the reason 👍 |
danielezonca
approved these changes
Jan 17, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danielezonca, davidesalerno, vaibhavjainwiz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
vaibhavjainwiz
added a commit
to vaibhavjainwiz/modelmesh-serving
that referenced
this pull request
Jan 17, 2024
…ub-io#262 Signed-off-by: Vaibhav Jain <[email protected]>
4 tasks
openshift-merge-bot bot
added a commit
that referenced
this pull request
Jan 17, 2024
Cherry-pick: Apply patch to remove empty string of caBundle #262
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This change is to fix https://issues.redhat.com/browse/RHOAIENG-244.
Modifications
Empty string of caBundle in
ValidationWebhookConfigurationcauses cyclic calling of reconcilation for DataScienceCluster controller. With this PR I had removed the empty caBundle string fromValidationWebhookConfiguration. Similiar patch is already applied in KServe manifest but missing in ModelMesh-Serving.Result
It should not impact any existing functionalities.
Testing Instruction
modelmesh-servingfolderPR checklist
Checklist items below are applicable for development targeted to both fast and stable branches/tags
Checklist items below are applicable for development targeted to both fast and stable branches/tags