WMS parameter values should not be case sensitive

[alexgleith]

• datacube-wms version: all

Description

Parameters values in this WMS implementation are case sensitive, and I don't think they should be.

The standard says:

6.4.1. Parameter Ordering and Case
Parameter names shall not be case sensitive, but parameter values shall be case sensitive.

So the implementation is technically correct...

But GeoServer, for example, is NOT case sensitive for most things, including parameter values, where it doesn't have to be.

What I Did

Try to get capabilities at ?service=wms&request=getcapabilities

Note that it only works with ?service=WMS&request=GetCapabilities.

[SpacemanPaul]

I am sorely tempted to close this as "complies with the standard" and suggest you file a bug report with either GeoServer or the OGC. :)

But in the name of pragmatism I will reluctantly make the service and request parameter values case-insensitive.

Note that this is not a general precedent. Other parameter values will be considered on case-by-case basis as requested but will most likely remain case-sensitive.

[SpacemanPaul]

(Or as my mother would put it: If Geoserver jumped off a cliff, would you?) :)

[SpacemanPaul]

Fixed in commit 8e33b20

[alexgleith]

hehe, thanks @SpacemanPaul

I think this makes it better, even if it does break the rules.