Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor test for FileStorage Base64 #26891

Merged
merged 1 commit into from
Feb 10, 2025
Merged

Refactor test for FileStorage Base64 #26891

merged 1 commit into from
Feb 10, 2025

Conversation

MaximSmolskiy
Copy link
Contributor

@MaximSmolskiy MaximSmolskiy commented Feb 8, 2025 •
edited
Loading

Pull Request Readiness Checklist

OpenCV extra: opencv/opencv_extra#1235

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@MaximSmolskiy MaximSmolskiy mentioned this pull request Feb 8, 2025
Merged
@MaximSmolskiy
Copy link
Contributor Author

Tried to fix tests by updating test data in opencv/opencv_extra#1235

@asmorkalov asmorkalov self-requested a review February 10, 2025 07:46
@asmorkalov asmorkalov self-assigned this Feb 10, 2025
@asmorkalov asmorkalov added test cleanup Code cleanup (e.g, drop legacy C-API, legacy unmaintained code) labels Feb 10, 2025
@asmorkalov asmorkalov added this to the 4.12.0 milestone Feb 10, 2025
asmorkalov pushed a commit to opencv/opencv_extra that referenced this pull request Feb 10, 2025
@MaximSmolskiy
Merge pull request #1235 from MaximSmolskiy:refactor-test-for-filesto…
eddc7ac 
…rage-base64

Refactor test for FileStorage Base64 #1235

Related to opencv/opencv#26891
@asmorkalov asmorkalov merged commit 1e013a0 into opencv:4.x Feb 10, 2025
27 of 29 checks passed
@MaximSmolskiy MaximSmolskiy deleted the refactor-test-for-filestorage-base64 branch February 10, 2025 10:42
@asmorkalov asmorkalov mentioned this pull request Feb 19, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asmorkalov asmorkalov asmorkalov approved these changes

Assignees

@asmorkalov asmorkalov

Labels
cleanup Code cleanup (e.g, drop legacy C-API, legacy unmaintained code) test
Projects
None yet
Milestone
4.12.0
Development

Successfully merging this pull request may close these issues.
2 participants
@MaximSmolskiy @asmorkalov