Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add Tracing Feature for Curve #2365

Closed
wants to merge 4 commits into from
Closed

Conversation

Ziy1-Tan
Copy link
Contributor

@Ziy1-Tan Ziy1-Tan commented Mar 31, 2023

What problem does this PR solve?

Hi! I want to try GSoC 2023, this's my rough idea and some tests.
Issue Number: #2229

Problem Summary:

Improve CurveBS observability by introducing Opentelemetry C++ SDK, Support features:

  • Visualization: export popular Monitoring Platforms: e.g. Zipkin, Jaeger
  • Configurable: enable tracing, export url, batch size, export interval...
  • Performance: impact: <1%
  • Good design: modular, can be applied to other modules
  • ...

when AioRead is called, trace is as follows:

┌─────────────────────────────────────────────┐
│  Client Span                                │
│  total time: 500ms                          │
│  status: OK                                 │
│  ...                                        │
│  ├── Server Span      ├──  Callback Span    │
│  │   duration: 200ms  │   duration: 100ms   │
│  │   status: OK       │   status: OK        │
│  │   ...              │   ...               │
└─────────────────────────────────────────────┘

What is changed and how it works?

What's Changed:

  • integrate SDK
    • introduce SDK
    • basic tests
  • AioRead/Write
    • nebd part (AioRead done/ AioWrite (WIP) )
    • curve client part
    • chunkserver part
  • performan test: using fio
  • docs:
    • design docs
    • manual (part)
  • Deploy: integrate Zipkin or Jaeger into curveadm deploy

How it Works:

Side effects(Breaking backward compatibility? Performance regression?):

Check List

  • Relevant documentation/comments is changed or added
  • I acknowledge that all my contributions will be made under the project's license

@ilixiaocui ilixiaocui requested a review from wu-hanqing April 4, 2023 01:52
Signed-off-by: Ziy1-Tan <[email protected]>
@caoxianfei1
Copy link
Contributor

@wu-hanqing

@Ziy1-Tan
Copy link
Contributor Author

Ziy1-Tan commented May 5, 2023

I've been a little busy lately, anyone can take it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants