validation: add more values for rlimits test #623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alban
reviewed
Apr 16, 2018
validation/process_rlimits.go
Outdated
| g.AddProcessRlimits("RLIMIT_CPU", 1024, 1024) | ||
| g.AddProcessRlimits("RLIMIT_DATA", 1024, 1024) | ||
| g.AddProcessRlimits("RLIMIT_FSIZE", 1024, 1024) | ||
| g.AddProcessRlimits("RLIMIT_STACK", 1024, 1024) |
There was a problem hiding this comment.
Could we use different values for each of the limits? So that it would check if the runtime does not mix them.
Ditto between the soft and hard value.
wking
reviewed
Apr 16, 2018
| @@ -17,7 +17,12 @@ func main() { | |||
| if err != nil { | |||
| util.Fatal(err) | |||
| } | |||
| g.AddProcessRlimits("RLIMIT_NOFILE", 1024, 1024) | |||
There was a problem hiding this comment.
RLIMIT_NOFILE is also in POSIX, so I don't think we want to drop this one. I'm in favor of adding the others.
There was a problem hiding this comment.
It has been added by GetDefaultGenerator().
There was a problem hiding this comment.
However the default generator uses the same value 1024 for the soft and hard value.
There was a problem hiding this comment.
updated, I add RLIMIT_NOFILE and use different value.
wking
reviewed
Apr 17, 2018
validation/process_rlimits.go
Outdated
| @@ -17,7 +17,12 @@ func main() { | |||
| if err != nil { | |||
| util.Fatal(err) | |||
| } | |||
| g.AddProcessRlimits("RLIMIT_NOFILE", 1024, 1024) | |||
| g.AddProcessRlimits("RLIMIT_AS", 100, 200) | |||
There was a problem hiding this comment.
This is not many bytes ;). Does it even run? Similarly for RLIMIT_DATA, RLIMIT_FSIZE, and RLIMIT_STACK below. I don't see a problem with making these generous values in the 1GB range, as long as they're distinct values.
|
I'd prefer different values both for soft & hard limits, and between the different kinds of limits. I tried the following: And it works with |
Test all getrlimit(3) values. Signed-off-by: Zhou Hao <[email protected]>
|
@alban updated, thanks for your suggestion. |
wking
approved these changes
Apr 19, 2018
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test all getrlimit(3) values.
Signed-off-by: Zhou Hao [email protected]