Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix condition in BlockIO test #595

Merged

Conversation

alban
Copy link
Contributor

@alban alban commented Mar 8, 2018

Symptoms:

$ sudo validation/linux_cgroups_relative_blkio.t

 not ok 6 - blkio leafWeight for 8:0 is set correctly
 # expect: 300, actual: 300

After the patch:

 ok 6 - blkio leafWeight for 8:0 is set correctly
 # expect: 300, actual: 300

Signed-off-by: Alban Crequy [email protected]

Symptoms:
```
$ sudo validation/linux_cgroups_relative_blkio.t

 not ok 6 - blkio leafWeight for 8:0 is set correctly
 # expect: 300, actual: 300
```

After the patch:
```
 ok 6 - blkio leafWeight for 8:0 is set correctly
 # expect: 300, actual: 300
```

Signed-off-by: Alban Crequy <[email protected]>
Copy link
Contributor

@wking wking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :). Sorry about the typo (it was me in #542).

@zhouhao3
Copy link

zhouhao3 commented Mar 9, 2018

LGTM

Approved with PullApprove

@zhouhao3 zhouhao3 merged commit 333d05d into opencontainers:master Mar 9, 2018
@alban alban deleted the alban/blkio-leafWeight branch March 12, 2018 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants