add annotation and prop tests

[liangchenye]

test cases for AnnotationsKeyReversedDomain, AnnotationsKeyReservedNS,
AnnotationsKeyIgnoreUnknown, ExtensibilityIgnoreUnknownProp and
ValidValues

Signed-off-by: Liang Chenye [email protected]

[liangchenye]

• add a random key to test 'AnnotationsKeyIgnoreUnknown'
• add an 'Unknown' proper to config.json to test 'ExtensibilityIgnoreUnknownProp'
• using invalid version to test 'ValidValues'
  but seems runc does not popup errors.

[liangchenye]

rebased, PTAL @q384566678

[zhouhao3]

I think it's better to return saveConfig(configFile, c.eSpec)

[liangchenye]

I'll update it.

[zhouhao3]

It was in a panic when I was testing. Here is the test. I'm looking for the reason.

➜  runtime-tools git:(4826ab8) ✗ ./oci-runtime-tool validate
key  SHOULD be named using a reverse domain notation
Refer to: https://github.com/opencontainers/runtime-spec/blob/v1.0.0/config.md#annotations
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x18 pc=0x575f02]

goroutine 1 [running]:
github.com/opencontainers/runtime-tools/vendor/github.com/hashicorp/go-multierror.(*Error).Error(0x0, 0x9eaea0, 0x0)
	/home/zhouhao/workspace/Go/src/github.com/opencontainers/runtime-tools/vendor/github.com/hashicorp/go-multierror/multierror.go:15 +0x22
github.com/opencontainers/runtime-tools/vendor/github.com/urfave/cli.HandleExitCoder(0x9eaea0, 0x0)
	/home/zhouhao/workspace/Go/src/github.com/opencontainers/runtime-tools/vendor/github.com/urfave/cli/errors.go:102 +0xff
github.com/opencontainers/runtime-tools/vendor/github.com/urfave/cli.Command.Run(0x801238, 0x8, 0x0, 0x0, 0x0, 0x0, 0x0, 0x807013, 0x16, 0x0, ...)
	/home/zhouhao/workspace/Go/src/github.com/opencontainers/runtime-tools/vendor/github.com/urfave/cli/command.go:196 +0xadc
github.com/opencontainers/runtime-tools/vendor/github.com/urfave/cli.(*App).Run(0xc420086b60, 0xc42000c080, 0x2, 0x2, 0x0, 0x0)
	/home/zhouhao/workspace/Go/src/github.com/opencontainers/runtime-tools/vendor/github.com/urfave/cli/app.go:250 +0x758
main.main()
	/home/zhouhao/workspace/Go/src/github.com/opencontainers/runtime-tools/cmd/oci-runtime-tool/main.go:50 +0x404

[liangchenye]

@q384566678 it works in my test, can you post your 'config.json' file?

[zhouhao3]

{
        "ociVersion": "1.0.0",
        "process": {
                "user": {
                        "uid": 0,
                        "gid": 0
                },
                "args": [
                        "sh"
                ],
                "env": [
                        "PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin",
                        "TERM=xterm"
                ],
                "cwd": "/"
        },
        "root": {
                "path": "rootfs"
        },
        "linux": {
                "resources": {
                        "devices": [
                                {
                                        "allow": false,
                                        "access": "rwm"
                                }
                        ]
                }
        },
        "annotations": {
                    "test": "22"
        }
}

[liangchenye]

@q384566678 thanks, I can reproduce it. Debugging now.

[liangchenye]

Very strange, if I add the following useless lines, it works. I'll continue to debug it tomorrow.

			if levelErrors.Error == nil {
				return nil
			}
 			return levelErrors.Error

[liangchenye]

The original code return *error instread of error. The new commit solves that.
It is more accurate to return levelErrors.Error.ErrorOrNil(). It works in my test.
PTAL @q384566678

[zhouhao3]

I don't quite understand what that does.

[liangchenye]

I use this to test ’runtimes that are reading or processing this configuration file MUST NOT generate an error if they encounter an unknown property‘. 'Unknown' here (in my commit) means the 'unknown property', so when a runtime reads this, it does not know what it means and it should not generete an error.

[zhouhao3]

LGTM

[alban]

using invalid version to test 'ValidValues' but seems runc does not popup errors.

I filed an issue about this: opencontainers/runc#1846