validate_test: add TestCheckMandatoryFields #554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because there are so many cases, I only chose part of the test. Signed-off-by: Zhou Hao <[email protected]>
zhouhao3
force-pushed
the
test-CheckMandatoryFields
branch
from
035a445 to
8769602
Compare
|
@liangchenye PTAL |
1 similar comment
|
@liangchenye PTAL |
|
Looking into this. |
|
It looks good. I just found the original function does not handle one case -- the 'v.spec == nil'. |
Signed-off-by: Zhou Hao <[email protected]>
|
updated, thanks. PTAL. |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because there are so many cases, I only chose part of the test.
Signed-off-by: Zhou Hao [email protected]