Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Complete Container Inside Test #521

Merged
merged 2 commits into from
Nov 21, 2017
Merged

Complete Container Inside Test #521

merged 2 commits into from
Nov 21, 2017
+128 −10

Conversation

Mashimiao
Copy link

  1. add preFunc() to set test environment before container running
  2. add all left behind tests for container inside validation

add preFunc
9a69e14 
With preFunc, we can build test envirionment before container runc

Signed-off-by: Ma Shimiao <[email protected]>
@Mashimiao Mashimiao force-pushed the complete-inside-test branch from ab53602 to 3e82a0a Compare November 21, 2017 06:55
@liangchenye
Copy link
Member

liangchenye commented Nov 21, 2017 •
edited by caniszczyk
Loading

LGTM

Approved with PullApprove

@liangchenye liangchenye added this to the v0.4.0 milestone Nov 21, 2017
@zhouhao3
Copy link

zhouhao3 commented Nov 21, 2017 •
edited by caniszczyk
Loading

LGTM

Approved with PullApprove

@zhouhao3 zhouhao3 merged commit 801ab0c into opencontainers:master Nov 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Mashimiao @liangchenye @zhouhao3