Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generate: fix DropProcessCapability* #519

Merged
merged 2 commits into from
Nov 28, 2017

Conversation

zhouhao3
Copy link

Signed-off-by: Zhou Hao [email protected]

@Mashimiao
Copy link

Mashimiao commented Nov 22, 2017

LGTM

Approved with PullApprove

@@ -1139,9 +1139,6 @@ func (g *Generator) DropProcessCapabilityEffective(c string) error {
// DropProcessCapabilityInheritable drops a process capability from g.spec.Process.Capabilities.Inheritable.
func (g *Generator) DropProcessCapabilityInheritable(c string) error {
cp := strings.ToUpper(c)
if err := validate.CapValid(cp, g.HostSpecific); err != nil {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liangchenye
Copy link
Member

liangchenye commented Nov 28, 2017

LGTM

Approved with PullApprove

@liangchenye liangchenye merged commit 7ebf1b1 into opencontainers:master Nov 28, 2017
@zhouhao3 zhouhao3 deleted the drop-caps-fix branch November 29, 2017 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants