runtimetest: add rootfs propagation test #511
Merged
+95
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mashimiao
force-pushed
the
add-rootfs-propagation
branch
from
1569616 to
60e3524
Compare
wking
reviewed
Nov 4, 2017
cmd/runtimetest/main.go
Outdated
| description: "rootfs propagation", | ||
| }, | ||
| { | ||
| test: validateRlimits, |
There was a problem hiding this comment.
Duplicate entry?
$ git grep -n validateRlimits origin/pr/511
origin/pr/511:cmd/runtimetest/main.go:271:func validateRlimits(spec *rspec.Spec) error {
origin/pr/511:cmd/runtimetest/main.go:803: test: validateRlimits,
origin/pr/511:cmd/runtimetest/main.go:850: test: validateRlimits,
There was a problem hiding this comment.
Oh, this is mistake, updated. Thanks.
| } | ||
| defer os.RemoveAll(targetDir) | ||
|
|
||
| switch spec.Linux.RootfsPropagation { |
There was a problem hiding this comment.
I think we probably want a default case that logs an “unrecognized linux.rootfsPropagation: …” warning.
Mashimiao
force-pushed
the
add-rootfs-propagation
branch
from
60e3524 to
fd2cb1b
Compare
|
On 11/04/2017 12:36 PM, W. Trevor King wrote:
These tests don't seem to distinguish between |slave| and |private|.
Yes, I have to admit that we can't in this PR.
Because we can't get the mount source of rootfs.
So, we can just judge propagation by binding rootfs.
Unfortunately, we get the same behaviour with slave and private rootfs after binding them.
Maybe we can find a way and fix this in the future.
|
|
According to https://www.kernel.org/doc/Documentation/filesystems/sharedsubtree.txt, |
|
The 'share' and 'unbind' looks good to me, just need to rebase. |
Mashimiao
force-pushed
the
add-rootfs-propagation
branch
from
fd2cb1b to
7026311
Compare
Signed-off-by: Ma Shimiao <[email protected]>
|
LGTM |
1 similar comment
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ma Shimiao [email protected]