generate: support blkio related options #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mashimiao
force-pushed
the
generate-add-blkio-options
branch
4 times, most recently
from
7f8c86c to
2c8f641
Compare
wking
reviewed
Oct 14, 2016
generate/generate.go
Outdated
| } | ||
|
|
||
| // SetLinuxResourcesBlockIOLeafWeightDevice sets g.spec.Linux.Resources.BlockIO.WeightDevice.LeafWeight. | ||
| func (g *Generator) SetLinuxResourcesBlockIOLeafWeightDevice(major int64, minor int64, weight uint16) { |
There was a problem hiding this comment.
Can you make the same Add*, drop, and “Can be specified multiple times…” changes you made to #247?
There was a problem hiding this comment.
Yes, I will update this PR in a few days.
Mashimiao
force-pushed
the
generate-add-blkio-options
branch
2 times, most recently
from
b5e1652 to
bcd9bb9
Compare
|
ping @wking @mrunalp @liangchenye fixed and rebased. |
Mashimiao
force-pushed
the
generate-add-blkio-options
branch
2 times, most recently
from
ee66578 to
b7bd4c2
Compare
Mashimiao
force-pushed
the
generate-add-blkio-options
branch
from
b7bd4c2 to
b1d3918
Compare
Mashimiao
force-pushed
the
generate-add-blkio-options
branch
from
b1d3918 to
10705c4
Compare
|
Rebased. @mrunalp @wking @liangchenye @hqhq PTAL |
Mashimiao
force-pushed
the
generate-add-blkio-options
branch
from
10705c4 to
a586fab
Compare
Signed-off-by: Ma Shimiao <[email protected]>
Mashimiao
force-pushed
the
generate-add-blkio-options
branch
from
a586fab to
a9c6787
Compare
|
LGTM |
1 similar comment
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ma Shimiao [email protected]