Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Complete the CLI args #556

Closed
4 tasks
liangchenye opened this issue Jan 22, 2018 · 0 comments
Closed
4 tasks

Complete the CLI args #556

liangchenye opened this issue Jan 22, 2018 · 0 comments

Comments

@liangchenye
Copy link
Member

liangchenye commented Jan 22, 2018 •
edited
Loading

Now we have CLI spec defined, we need to complete the 'args' of 'create/kill' in 'validation/util/container' .

  • add lifecycle testing function
    working on Fix #556  #557
  • create with 'pid-file'
    working on Fix #556  #557
  • create with 'socket'
    I don't have an idea to implement it now.
  • kill with 'signal'
    'runc' does not follow this yet or we can implement it by writing a process which track the kill signal
liangchenye added a commit to liangchenye/ocitools that referenced this issue Jan 22, 2018
@liangchenye
WIP: Fix opencontainers#556
ae63341 
Signed-off-by: Liang Chenye <[email protected]>
liangchenye added a commit to liangchenye/ocitools that referenced this issue Jan 22, 2018
@liangchenye
WIP: Fix opencontainers#556
56857d8 
Signed-off-by: Liang Chenye <[email protected]>
liangchenye added a commit to liangchenye/ocitools that referenced this issue Jan 22, 2018
@liangchenye
WIP: Fix opencontainers#556
b483dc1 
Signed-off-by: Liang Chenye <[email protected]>
liangchenye added a commit to liangchenye/ocitools that referenced this issue Jan 22, 2018
@liangchenye
WIP: Fix opencontainers#556
78f41b5 
Signed-off-by: Liang Chenye <[email protected]>
liangchenye added a commit to liangchenye/ocitools that referenced this issue Jan 23, 2018
@liangchenye
Add lifecycle test function; Add pidfile test.
9df90d8 
Fixes opencontainers#556

Signed-off-by: Liang Chenye <[email protected]>
liangchenye added a commit to liangchenye/ocitools that referenced this issue Jan 23, 2018
@liangchenye
Add lifecycle test function; Add pidfile test.
08d0bd1 
Fixes opencontainers#556

Signed-off-by: Liang Chenye <[email protected]>
liangchenye added a commit to liangchenye/ocitools that referenced this issue Jan 24, 2018
@liangchenye
Add lifecycle testing function; Add pidfile test.
a7f123b 
Fixes opencontainers#556

Signed-off-by: Liang Chenye <[email protected]>
zhouhao3 pushed a commit that referenced this issue Jan 25, 2018
Merge pull request #557 from liangchenye/cli-complete
7ac117a 
Fix #556
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@liangchenye