Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

specs-go: add consts for seccomp flags #1108

Closed
wants to merge 1 commit into from
Closed

specs-go: add consts for seccomp flags #1108

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions specs-go/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -613,6 +613,13 @@ type Arch string
// LinuxSeccompFlag is a flag to pass to seccomp(2).
type LinuxSeccompFlag string

// LinuxSeccompFlag options
const (
FlagTSync LinuxSeccompFlag = "SECCOMP_FILTER_FLAG_TSYNC"
Copy link
Member

@rata rata Jul 30, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure we want to add a const for this. This flag should probably not be used, as we asked here: #1077.

Maybe it is better to not facilitate using it, or even better mark it as deprecated in the spec? (the latter is out of scope for this PR, but a follow-up PR to discuss it would be great IMHO).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point; I'm fine with removing this one; I wasn't aware of the other discussion 👍

FlagLog LinuxSeccompFlag = "SECCOMP_FILTER_FLAG_LOG"
FlagAllow LinuxSeccompFlag = "SECCOMP_FILTER_FLAG_SPEC_ALLOW"
)

// Additional architectures permitted to be used for system calls
// By default only the native architecture of the kernel is permitted
const (
Expand Down