Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Giuseppe Scrivano as a runtime spec maintainer #1048

Merged
merged 1 commit into from
Sep 29, 2020
Merged

Add Giuseppe Scrivano as a runtime spec maintainer #1048

merged 1 commit into from
Sep 29, 2020

Conversation

mrunalp
Copy link
Contributor

@mrunalp mrunalp commented May 29, 2020 •
edited by cyphar
Loading

@giuseppe ptal.

@opencontainers/runtime-spec-maintainers ptal.

Needs at least two-thirds to pass (5 LGTMs).

Signed-off-by: Mrunal Patel [email protected]

giuseppe
giuseppe approved these changes May 29, 2020
View reviewed changes
Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

LGTM

@thaJeztah
Copy link
Member

thaJeztah commented May 29, 2020 •
edited
Loading

@vbatts looks like your e-mail needs an update as well (it's almost mailing-list day!)

edit: oh, and @crosbymichael as well

@mrunalp
Copy link
Contributor Author

mrunalp commented May 29, 2020

@thaJeztah yeah I noticed that while making this PR but we can handle those as separate PRs :)

@AkihiroSuda
Copy link
Member

ping @opencontainers/runtime-spec-maintainers

@hqhq
Copy link
Contributor

hqhq commented Jun 5, 2020 •
edited by caniszczyk
Loading

LGTM

Approved with PullApprove

@caniszczyk
Copy link
Contributor

friendly ping @opencontainers/runtime-spec-maintainers

@cyphar
Copy link
Member

cyphar commented Jul 23, 2020 •
edited by caniszczyk
Loading

LGTM, I forgot about this. This cannot be merged yet -- I'll update the PR description to include the current vote.

/cc @opencontainers/runtime-spec-maintainers

Approved with PullApprove

@vbatts
Copy link
Member

vbatts commented Jul 23, 2020 •
edited by caniszczyk
Loading

yay!
LGTM
(and yes, my email needs to be updated)

Approved with PullApprove

@vbatts
Copy link
Member

vbatts commented Sep 14, 2020

to get movement on this, @giuseppe might you provide a bit more of context on contributions and reasoning behind the recommendation here? activity, contributions, etc.
(not everyone has worked with you)

@giuseppe
Copy link
Member

to get movement on this, @giuseppe might you provide a bit more of context on contributions and reasoning behind the recommendation here? activity, contributions, etc.
(not everyone has worked with you)

I am the main author of crun. I've got the most experience with the runtime specs working on it.

I've also contributed some other fixes for the runtime-specs: https://github.com/opencontainers/runtime-spec/pulls?q=is%3Apr+author%3Agiuseppe, in particular I've worked on adding support for cgroup v2: #1040

crosbymichael
crosbymichael approved these changes Sep 28, 2020
View reviewed changes
Copy link
Member

@crosbymichael crosbymichael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tianon
Copy link
Member

tianon commented Sep 28, 2020 •
edited by caniszczyk
Loading

Thanks for adding some additional detail (and for your work here)!

LGTM

Approved with PullApprove

@cyphar
Copy link
Member

cyphar commented Sep 29, 2020

Passes with 6 LGTMs (of 5 required), welcome to the crew @giuseppe!

@cyphar cyphar closed this in e6143ca Sep 29, 2020
@cyphar cyphar merged commit e6143ca into opencontainers:master Sep 29, 2020
@giuseppe
Copy link
Member

thanks everyone! 😄

@AkihiroSuda AkihiroSuda mentioned this pull request Jan 24, 2023
Merged
@AkihiroSuda AkihiroSuda added this to the v1.1.0 milestone Feb 1, 2023
@AkihiroSuda AkihiroSuda mentioned this pull request Jun 26, 2023
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crosbymichael crosbymichael crosbymichael approved these changes

@giuseppe giuseppe giuseppe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.1.0
Development

Successfully merging this pull request may close these issues.
10 participants
@mrunalp @thaJeztah @AkihiroSuda @hqhq @caniszczyk @cyphar @vbatts @giuseppe @tianon @crosbymichael